Declare matrix-project a mandatory dependency it actually is #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dheid, can you please integrate this and cut a release? This is one of the few outstanding false positives[1] for certifying Jenkins for Java 11 we would like to get into 1.264.1. Thanks! |
|
Sorry for the delay. I was very busy the last days. |
|
I will release a new version as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 extensions in the plugin and both depend on matrix plugin classes. One was marked as optional to handle this situation but I fail to see the point in hiding all extensions of the plugin in case matrix is not installed. Therefore, I declare the dependency to be mandatory.
Verified manually this actually fixes https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-482/2/testReport/plugins/PostBuildScriptPluginTest/