Skip to content

Conversation

@basil
Copy link
Member

@basil basil commented Sep 14, 2023

I cannot see a reason to continue using mrm-maven-plugin. Based on https://www.mojohaus.org/mrm/mrm-maven-plugin/examples/invoker-tests.html it seems the reason for using it was originally

to allow the integration tests of a Maven Plugin to be run against a test local repository thereby ensuring that the plugin does not get installed into the local repository until after the integration tests have been confirmed as passing

but I just ran mvn clean verify and my local ~/.m2 repository did not seem to get polluted, so I don't think this is a concern anymore now that we are configuring maven-invoker-plugin with localRepositoryPath.

For what it's worth, I asked Maven developer Tamás Cservenák to audit maven-hpi-plugin a few months back, and here is what he had to say:

I'd avoid the use of mrm plugin. You already pull Jetty, simplest (and most straightforward and least error prone) is to just fire up Jetty to serve files from somewhere as "remote repository" as in that case you are 100% in control of what is being served, while with MRM you are not.

@basil basil added the test label Sep 14, 2023
@basil basil merged commit 29e122c into jenkinsci:master Sep 14, 2023
basil added a commit that referenced this pull request Sep 14, 2023
basil added a commit that referenced this pull request Sep 14, 2023
@basil basil added skip-changelog and removed test labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant