JTH 2.46 #153
Merged
JTH 2.46 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Jan 23, 2019
batmat
approved these changes
Jan 23, 2019
|
Note that it may include some fun, because 2.45 includes binary-incompatible changes in HtmlUnit. We should explicitly reference it in the changelog, I'd guess |
Really? It looks like the last significant change on HtmlUnit (2.18 => 2.31) was introduced in JTH 2.42. And this JTH version (or 2.43 actually) was first introduced in plugin-pom 3.24. |
|
Even worse. It was in 2.41: https://github.com/jenkinsci/jenkins/blob/master/test-pom/pom.xml#L57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply bump JTH version to 2.46.
This PR replaces #93.