Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend-maven-plugin from 1.4 to 1.6 #138

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

batmat
Copy link
Member

@batmat batmat commented Dec 2, 2018

Version upgrade of the frontend-maven-plugin.

I believe we can safely do this globally given Blue Ocean already updated to this version a year ago: https://github.com/jenkinsci/blueocean-plugin/blob/master/pom.xml#L32 / jenkinsci/blueocean-plugin#1464

@batmat batmat closed this Dec 2, 2018
@batmat batmat reopened this Dec 2, 2018
@batmat batmat mentioned this pull request Dec 3, 2018
1 task
@batmat batmat closed this Dec 4, 2018
@batmat batmat reopened this Dec 4, 2018
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with workflow-cps-plugin I guess.

batmat added a commit to batmat/workflow-cps-plugin that referenced this pull request Dec 6, 2018
DO NOT MERGE. Goal is to test jenkinsci/plugin-pom#138
and so this bump will occur through some future parent pom update,
NOT by merging this.
@batmat
Copy link
Member Author

batmat commented Dec 6, 2018

Filed jenkinsci/workflow-cps-plugin#269 after Jesse's comment.

Will merge this if this PR succeeds, as I've already many approvals apart from this.

Thanks everyone.

@batmat
Copy link
Member Author

batmat commented Dec 6, 2018

OK, build succeeded there. Merging.

image

@batmat batmat merged commit 5901185 into jenkinsci:master Dec 6, 2018
@batmat batmat deleted the update-frontend-m-p-to-1.6 branch December 6, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants