Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-52155] default animal sniffer version 1.17 #115

Merged

Conversation

olamy
Copy link
Member

@olamy olamy commented Jun 25, 2018

No description provided.

@olamy olamy added the java label Jun 25, 2018
@olamy olamy requested a review from oleg-nenashev June 25, 2018 03:35
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a changelog link for it just in case?

@batmat
Copy link
Member

batmat commented Jun 25, 2018

@olamy I think it would be much preferrable to 1) deploy a SNAPSHOT of this pom and 2) file a PR to the core with that timestamped one to check it builds correctly on the core WDYT?

@oleg-nenashev
Copy link
Member

  1. file a PR to the core with that timestamped one to check it builds correctly on the core WDYT?

Jenkins core uses another Parent POM (https://github.com/jenkinsci/pom), so it's quite impossible. regarding this version of Animal Sniffer, It has been actually tested in jenkinsci/workflow-support-plugin#67

@batmat
Copy link
Member

batmat commented Jun 25, 2018

My bad. I misread the project name here indeed. Not pom, so please ignore my previous comment.

@oleg-nenashev oleg-nenashev self-assigned this Jun 30, 2018
@oleg-nenashev oleg-nenashev merged commit 3e85f7e into jenkinsci:master Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants