Update baseline, POM, BOM #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
reviewed
Jan 4, 2023
| useContainerAgent: true, | ||
| configurations: [ | ||
| [platform: 'linux', jdk: 17], | ||
| [platform: 'windows', jdk: 11], |
There was a problem hiding this comment.
as mentioned before - this is not something I believe is good. it saves some compute $$$ but does not save any wall clock time on the build and makes windows related issues more of "is this windows or jdk" in a non obvious way (esp when the tests pass locally due to some timing thing..
There was a problem hiding this comment.
This Jenkinsfile is currently the stock recommendation. If you wish to suggest a different stock Jenkinsfile, run it by ci.jenkins.io admins and propose that change in archetypes.
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
jtnord
reviewed
Jan 4, 2023
jtnord
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #38, #39, & #42.