Require Jenkins 2.452.4 or newer #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
added a commit
to MarkEWaite/repository-permissions-updater
that referenced
this pull request
Nov 23, 2024
jenkinsci/last-changes-plugin#97 needs to be merged and released so that users of the last-changes plugin are not disrupted when they upgrade to git client 5.0.0 or git client plugin 6.0.0. $The pull request was submitted in September. There has been no response from @rmpestano. jenkinsci/last-changes-plugin#97 (comment) That pull request is a minimal change that adapts to git client plugin 5.0.0 and later without unnecessary changes. Other changes to modernize the plugin can be considered once the immediate issue with newer versions of git client plugin has been resolved. jenkinsci/last-changes-plugin#98 includes several steps to modernize the plugin, though it has not been tested yet.
Use plugin BOM to provide versions of dependencies. Remove the unnecessary release profile. Remove the unnecessary configuration of the animal sniffer plugin. Rely on the parent pom. Reduce spotbugs effort and threshold to match previous behavior.
Simplify pom without reducing coverage
MarkEWaite
force-pushed
the
modernize-plugin
branch
from
6ea137a to
0df368f
Compare
Also improve test performance by starting the JenkinsRule only once for all the tests in the class.
invalid build number
Test leaves an open file handle and that correctly fails the test on Windows. Needs more research to identify and fix the leaked file handle.
https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-last-changes.yml is the accurate definition of the current maintainers of the plugin.
Noise from the test does not help diagnosis of test failures
Use GitSampleRepoRule to provide a repository
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require Jenkins 2.452.4 or newer
Use plugin BOM to provide versions of dependencies.
Remove the unnecessary configuration items in the pom. Rely on the parent pom.
Reduce spotbugs effort and threshold to match previous behavior.
Multiple other changes to adapt to Java 11, the most recent parent pom, and the most recent dependencies.
Supersedes pull requests:
Testing done
Automated tests pass. Interactive testing is still needed before this is merged.
Submitter checklist