The pod watcher now checks readiness of the right pod. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves the issue I described in #95 (comment) 👍 |
|
@carlossg: So, do we review everything, or simple commits like this can go in directly? |
|
we can use github PR review for now, but you can create the branches in this repo if it is easier to share work |
carlossg
approved these changes
Dec 1, 2016
|
While we're at it, quick question: Does Jenkins/the community require that issues are reported through Jira, or can GitHub Issues also be enabled on this repository? Just asking, because I'm not really a fan of Jira and to me it feels like an extra barrier compared to GitHub issues, but I can understand that it makes global ticket/issue management of all things Jenkins a lot easier if it's all combined in one system. |
|
They should go through Jira |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.