[JENKINS-50196] Fix nested Pod Templates support #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using PodTemplateAction and NamespaceAction, pass a new PodTemplateContext object that will be accessible by nested steps
fbelzunc
approved these changes
Oct 4, 2018
carlossg
approved these changes
Oct 4, 2018
jglick
reviewed
Oct 5, 2018
src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/NamespaceAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesPipelineTest.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Oct 5, 2018
src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/NamespaceAction.java
Show resolved
Hide resolved
Vlatombe
force-pushed
the
JENKINS-50196
branch
from
25b7800
to
b96bd14
Compare
|
@carlossg could you perform a release after this PR is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using PodTemplateAction and NamespaceAction, pass a new
PodTemplateContext object that will be accessible by nested steps