Expose pod cfg via yaml to UI and merge tolerations

[gabemontero]

…lerations

Per discussion in #275 (comment) and #275 (comment)

And for https://trello.com/c/XBOXKjYA/1446-3-add-pod-tolerations-to-slave-pods-jenkinsintegration

@carlossg @bparees fyi / ptal

[gabemontero]

(3) Add pod tolerations to slave pods [jenkins_integration]

[bparees]

lgtm.

[carlossg]

must it ?

[gabemontero]

Nope, you are right. Just need enough context ... i.e.

spec:
   tolerations:
      - key: CriticalAddonsOnly
        operator: Exists

works, but

   tolerations:
      - key: CriticalAddonsOnly
        operator: Exists

Does not since the code puts in a empty spec if one is not specified. I didn't try the middle ground before.

I'll update the help for this as well.

thanks

[carlossg]

This would never replace parent tolerations, always append. Is that the expected behavior ?
IIUC you can have multiple tolerations with the same key, but just checking

[gabemontero]

Yeah, per https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ you can have the same key with different contents ...several examples on that page that do that.

On whether to override or add ... for our uses cases at least, we can make some simplifying assumptions wrt the yaml field being the starting point, and most likely there won't be existing tolerations that we have to worry about overriding.

So I'm good with keeping it simple and not adding more levers around tuning the behaviour. But if you want those let me know.

[gabemontero]

Though upon re-reading the help text, it could be misleading wrt that ... I'll update it to clarify.

[gabemontero]

updates pushed in separate commit ... can squash on your say-so @carlossg

[gabemontero]

bump @carlossg

[gabemontero]

thanks @carlossg !

If there is a schedule for new releases of this plugin, apologies, I could not find it poking around the wiki, etc.

So I'll ask here: any sense on when a new version of this plugin, with this commit, will be cut?

thanks again

[carlossg]

there is no schedule but I try to release on every new commit

[nick4fake]

It has somehow broken pod count limit.

[nick4fake]

Sorry, just checked this PR. My problem is not related to it, but there seems to be a bug with yaml merging.

[nick4fake]

Okay, so it looks like we need to manually add label to pod yaml:

apiVersion: v1
kind: Pod
metadata:
  labels:
    jenkins/kube-default: true
    app: jenkins
    component: agent
spec:
  nodeSelector:
    werkint.com/entity: other
  tolerations:
  - key: werkint.com/entity
    operator: Equal
    value: other
    effect: NoSchedule