[JENKINS-47178] Replace Windows path separator with Unix path separator

[ghost]

Use Unix path separator in volume mount paths

Signed-off-by: Alex Johnson ajohnson@bombora.com

[Vlatombe]

What issue is this fixing? Would be great to add a test as well.

[ghost]

@Vlatombe: If the Jenkins master is running on a Windows machine, the Path.toString function uses the Windows path separator in volume mount paths.

[ghost]

volumeMounts:
    - mountPath: \usr\bin\docker
      name: volume-2
    - mountPath: \root\workspace
      name: volume-0
    - mountPath: \var\run\docker.sock
      name: volume-1

[ghost]

@Vlatombe: And regarding tests, are there any tests that are currently testing volume creation?

[Vlatombe]

@TheOriginalAlex Thanks for providing the context.
If I understand the issue correctly, it means that the existing test class org.csanchez.jenkins.plugins.kubernetes.PodTemplateBuilderTest fails on windows and should be fixed by this PR. Could you confirm?

@carlossg I guess the best way to handle such problems would be to have a tests running on windows.

[carlossg]

That test is already passing on windows, maybe needs some extra checks
https://ci.jenkins.io/job/Plugins/job/kubernetes-plugin/job/master/173/testReport/org.csanchez.jenkins.plugins.kubernetes/PodTemplateBuilderTest/

[Vlatombe]

@carlossg ah right, it's loading definition from yaml files, so it doesn't go through the path getting changed here.

Probably just a matter of creating a new test case that is declaring a volume mount using the PodTemplateBuilder methods directly.

[ghost]

@Vlatombe, @carlossg: Should I go ahead and add that test?

[Vlatombe]

@TheOriginalAlex yes, it would be great to avoid regressions.

[ghost]

Wouldn't making this setYaml function in org.csanchez.jenkins.plugins.kubernetes.PodTemplate load contents of the yaml into the object properties (i.e. this.volumes) ensure that the existing tests catch these errors?

@DataBoundSetter
public void setYaml(String yaml) {
    this.yaml = yaml;
}

[ghost]

Or is there a specific reason why only the string version of the yaml is stored in the object?

[Vlatombe]

The yaml allows to support any kind of field supported by kubernetes that may not be implemented by the plugin.

[ghost]

@Vlatombe: Got it! Thanks for the clarification!

[carlossg]

wrong package name

[carlossg]

the test is failing with

ERROR] testBuildFromTemplate(org.csanchez.jenkins.plugins.kubernetes.PodTemplateBuilderTest)  Time elapsed: 0.005 s  <<< FAILURE!

java.lang.AssertionError

	at org.junit.Assert.fail(Assert.java:86)

	at org.junit.Assert.assertTrue(Assert.java:41)

	at org.junit.Assert.assertNotNull(Assert.java:712)

	at org.junit.Assert.assertNotNull(Assert.java:722)

	at org.csanchez.jenkins.plugins.kubernetes.PodTemplateBuilderTest.validatePod(PodTemplateBuilderTest.java:155)

	at org.csanchez.jenkins.plugins.kubernetes.PodTemplateBuilderTest.testBuildFromTemplate(PodTemplateBuilderTest.java:128)

[ghost]

@carlossg: Finally got around to fixing the tests... sorry about the delay!

[carlossg]

thanks!