Pod annotations cannot contain duplicate keys when combining pod templates #220
Conversation
| podAnnotations.addAll(template.getAnnotations()); | ||
|
|
||
| podAnnotations.addAll(parent.getAnnotations()); |
There was a problem hiding this comment.
Maybe I am wrong, but this looks like the precedence favors parent, not as you write, template:
changed precedence so that the template will override the parent in inheritance.
Why do you want to change the precedence in the first place? Reading the documentation, I would expect the template to have precedence.
There was a problem hiding this comment.
I thought the same but actually he is right
https://docs.oracle.com/javase/7/docs/api/java/util/HashSet.html#add(E)
Adds the specified element to this set if it is not already present.
There was a problem hiding this comment.
You are right, makes sense when you think about it.
| podAnnotations.addAll(template.getAnnotations()); | ||
|
|
||
| podAnnotations.addAll(parent.getAnnotations()); |
There was a problem hiding this comment.
I thought the same but actually he is right
https://docs.oracle.com/javase/7/docs/api/java/util/HashSet.html#add(E)
Adds the specified element to this set if it is not already present.
Added equals and hashCode overrides to podAnnotations so that combining doesn't allow duplicate keys Also, changed precedence so that the template will override the parent in inheritance.