JENKINS-46085 containerLog step to get the logs of a container running in the slave pod #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
reviewed
Aug 11, 2017
| @@ -321,6 +321,18 @@ public void declarative() throws Exception { | |||
| r.assertLogContains("Apache Maven 3.3.9", b); | |||
| } | |||
|
|
|||
| @Issue("JENKINS-46085") | |||
There was a problem hiding this comment.
can we have this test in a new file ContainerLogStepTest.java, this one is getting too big
added 4 commits
August 16, 2017 10:06
marvinthepa
force-pushed
the
feature/JENKINS-46085-container-log-pipeline-step
branch
from
947c1b9 to
414cd73
Compare
|
@carlossg: implemented the missing parameters, added license headers, extracted the test, fixed the build, and rebased master. |
marvinthepa
changed the title
containerLog step to get the logs of a container running in the slave pod
|
I'm getting a test error with minikube |
marvinthepa
force-pushed
the
feature/JENKINS-46085-container-log-pipeline-step
branch
from
414cd73 to
43cb9e4
Compare
|
Right, I made a mistake when rebasing master (too tired, probably). Please try again. |
|
thanks! |
|
One thing that is missing is adding some docs to the readme, if you can add a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge yet, as I will add the missing parameters that the API supports
(
withTerminatedStatus sinceSeconds sinceTimestamp withTailingLines limitBytes).I just wanted to get early feedback, especially on the way I extracted the common code from
ContainerStepExecution.