Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesAgentErrorCondition failed to handle DR #1617

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 4, 2024

I ran a disaster recover scenario where a controller started in a fresh cluster with no record of old Pods. Of course the agent used by a running build did not reattach, but then the log printed

Ignored termination reason(s) for …-f8fp6-qkfpk-htdxt for purposes of retry: []

and did not retry the stage. In this scenario we do not expect there to be any recorded termination reasons, so we do want to retry. I suspect this is a regression from #1582.

(CloudBees-internal reference)

@jglick jglick added the bug Bug Fixes label Nov 4, 2024
@jglick jglick requested a review from a team as a code owner November 4, 2024 22:44
@Vlatombe Vlatombe merged commit 20a7e4d into master Nov 5, 2024
8 checks passed
@Vlatombe Vlatombe deleted the jglick-patch-1 branch November 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants