Make the name field in the pod template the pod name #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iocanel
reviewed
Feb 15, 2017
| @@ -44,7 +44,8 @@ public boolean start() throws Exception { | |||
| cloud.getClass().getName())); | |||
| } | |||
| KubernetesCloud kubernetesCloud = (KubernetesCloud) cloud; | |||
| String name = String.format(NAME_FORMAT, UUID.randomUUID().toString().replaceAll("-", "")); | |||
| String uuid = UUID.randomUUID().toString().replaceAll("-", ""); | |||
There was a problem hiding this comment.
This line, seems unnecessary to me.
There was a problem hiding this comment.
he just split it into two lines
LGTM
iocanel
approved these changes
Feb 15, 2017
carlossg
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, you can set
namein thepodTemplate, and the pod launched in K8s will have the name set (with random UUID at the end). It will also sets the Jenkins Node name.