Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing Java 11 #622

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

strangelookingnerd
Copy link
Contributor

Stop testing Java 11

Jenkins stopped supporting Java 11 with the release of Jenkins 2.463 (weekly) and Jenkins 2.479.1 (LTS). Most plugins stopped spending ci.jenkins.io time to run tests that are specific to Java 11.

Let's save money and time by removing the Java 11 test configuration. It has not found any issues that are not also found with Java 17 and Java 21.

Jenkins plugin BOM still tests with Java 11 on older lines (currently 2.452.x and 2.462.x) and the plugin build will continue to generate Java 11 byte code until the parent pom is upgraded to 5.x and the minimum Jenkins version is upgraded to 2.479.1.

Switches to test Java 17 / Java 21 since to match the test configuration used in the plugin archetype.

Testing done

None. Rely on ci.jenkins.io to test it.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 10, 2025 08:59
forkCount: '1C', // run this number of tests in parallel for faster feedback. If the number terminates with a 'C', the value will be multiplied by the number of available CPU cores
useContainerAgent: true, // Set to `false` if you need to use Docker for containerized tests
configurations: [
[platform: 'linux', jdk: 21],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rantoniuk
Copy link
Contributor

rantoniuk commented Jan 10, 2025

pom.xml needs also updating to reference minimum Jenkins version to be 2.479.3, to pave the way for https://github.com/jenkinsci/jira-plugin/pull/613/files to be merged.

I see that Jenkins build is running for Started 175m ago already... that's not expected, is it?

@strangelookingnerd
Copy link
Contributor Author

I see that Jenkins build is running for Started 175m ago already... that's not expected, is it?

There seems to be some temporary outage for the windows agents -> jenkins-infra/helpdesk#4490
Unfortunate timing on my end, but I'm certain the issues will be resolved and the PR can be merged just fine.

@rantoniuk
Copy link
Contributor

I see that Jenkins build is running for Started 175m ago already... that's not expected, is it?

There seems to be some temporary outage for the windows agents -> jenkins-infra/helpdesk#4490 Unfortunate timing on my end, but I'm certain the issues will be resolved and the PR can be merged just fine.

Do you mind updating pom.xml as well accordingly to reference the proper LTS that goes with this change?

@strangelookingnerd
Copy link
Contributor Author

Do you mind updating pom.xml as well accordingly to reference the proper LTS that goes with this change?

Upgrading towards the latest 2.479.x LTS line will require additional effort that is far beyond the scope of this PR. I will however look into it in a seperate PR.

@rantoniuk rantoniuk merged commit 8031891 into jenkinsci:master Jan 10, 2025
15 of 17 checks passed
@rantoniuk rantoniuk removed the breaking Release Drafter label label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants