-
-
Notifications
You must be signed in to change notification settings - Fork 292
depend on jersey2-api #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to avoid class path conflicts
pom.xml
Outdated
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>jersey2-api</artifactId> | ||
| <!-- TODO remove the explicit version number once this has made it into the plugin BOM --> | ||
| <version>2.35-7</version> <!-- TODO https://github.com/jenkinsci/bom/pull/1022 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need release of
jenkinsci/bom#1022
|
@rantoniuk would you be able to take the HPI and do some sanity testing? I don't have test setup for Jira 😅 |
basil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @dcendents had a way of reproducing the problem? It would be nice to get confirmation that the incremental build from this PR resolves the issue.
|
@rantoniuk I think you can remove the waiting for LTS label. Nothing has changed from the HPI point of view. Though I appreciate if someone would be able to test it. I don't use Jira 😅 |
|
As I mentionned before we don't really use the JIRA plugin but since we have a JIRA instance here I tried the incremental build. It correctly scanned the JIRA issue from the git comment and added a link in the jenkins changes section. I could not see any errors in the logs (but I am plagued by https://issues.jenkins.io/browse/JENKINS-68057 so hopefully I didn't miss it) |
|
Thanks for doing a smoke test Daniel. From my perspective this is ready to land. |
|
It's waiting for @olamy since he asked to stop merging any PRs temporarilly because of preparing a security release. |
to avoid class path conflicts. Currently class path conflicts exist between gitlab-api plugin and jira plugin
cc @basil @dcendents
jenkinsci/jersey2-api-plugin#19
🚨 Please review the guidelines for contributing to this repository.