Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ProcessHandle.destroy to implement RealJenkinsRule.stopJenkins #544

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Use ProcessHandle.destroy to implement RealJenkinsRule.stopJenkins #544

merged 1 commit into from
Jan 18, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 17, 2023

As of jenkinsci/winstone#310 we will get final log messages even without an explicit call path to Jenkins.cleanUp, so there is no need for a special exit endpoint.

@jglick jglick requested a review from Vlatombe January 17, 2023 20:12
@jglick jglick merged commit fb39b60 into jenkinsci:master Jan 18, 2023
@jglick jglick deleted the destroy branch January 18, 2023 13:13
@dwnusbaum
Copy link
Member

Note that when using RealJenkinsRule in tests against plugins which have picked up this PR (i.e. parent POM >= 4.54) but not jenkinsci/jenkins#7632 (i.e. Jenkins >= 2.391), shutdown-related log output is lost.

@jglick jglick mentioned this pull request Mar 6, 2023
Merged
7 tasks
@jglick
Copy link
Member Author

jglick commented Mar 6, 2023

Correct.

@dwnusbaum dwnusbaum mentioned this pull request Mar 6, 2023
Merged
6 tasks
dwnusbaum added a commit that referenced this pull request Mar 7, 2023
@dwnusbaum
Revert "Merge pull request #544 from jglick/destroy"
9ec7885 
This reverts commit fb39b60, reversing
changes made to eb817ec.
jglick added a commit that referenced this pull request Mar 7, 2023
@jglick
Merge pull request #559 from jenkinsci/ensure-rjr-cleans-up
0efff5a 
Revert #544 so that `RealJenkinsRule` shuts down cleanly on Windows
@jglick jglick mentioned this pull request Mar 6, 2024
Draft
@jglick jglick mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @dwnusbaum @Vlatombe