Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the GitHub repo URLs to the Maven metadata #191

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Add the GitHub repo URLs to the Maven metadata #191

merged 1 commit into from
Jan 27, 2020

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jan 6, 2020

I doubt dependabot can resolve variables in the URL as it reading XML directly instead of parsing variables.

I doubt dependabot can resolve variables in the URL as it reading XML directly instead of parsing variables.
@jglick

This comment has been minimized.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot changelog managementin PRs is a mess anyway at the moment, but this is a net improvement

@oleg-nenashev oleg-nenashev changed the title fix URL Add the GitHub repo URLs to the Maven metadata Jan 20, 2020
<description>Harness used to run functional tests of Jenkins core and plugins.</description>

<scm>
<connection>scm:git:git://github.com/jenkinsci/${project.artifactId}.git</connection>
<developerConnection>scm:git:ssh://git@github.com/jenkinsci/${project.artifactId}.git</developerConnection>
<url>https://github.com/jenkinsci/${project.artifactId}</url>
<url>https://github.com/jenkinsci/jenkins-test-harness</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather just fix the bug in Dependabot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests that should cover the use case but it's clearly not happening. 🤔

@oleg-nenashev oleg-nenashev merged commit 3f70421 into jenkinsci:master Jan 27, 2020
@jetersen jetersen deleted the patch-1 branch January 28, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants