Avoid printing duplicated messages when LoggerRule is used #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some description would be nice |
|
Sorry, thought the commit message plus comment would explain themselves, but I guess this more subtle than that. Will add a PR description. |
oleg-nenashev
approved these changes
Jun 13, 2019
jglick
added a commit
to jglick/jenkins-test-harness
that referenced
this pull request
Jul 1, 2019
jglick
added a commit
that referenced
this pull request
Jul 1, 2019
Reverting #138 as it broke display of FINE- messages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggerRulehas two basic functions:FINEor lower messages from particular loggers in test output. (record)capture)For the
recordaspect, there was an unfortunate side effect that messages to those loggers atINFOor above got printed once for the general system logger (formatted nicely byJenkinsRule), plus once per matchingLoggerRule. So the test output would get multiple copies of lots of messages, which was harmless but irritating.Not trivially testable, but tried it interactively in jenkinsci/kubernetes-plugin#503 and it seemed to do the job.