[JENKINS-73774] Stop overriding #printStackTrace and #getCause in JellyException
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
changed the title
#printStackTrace and #getCause in JellyException
daniel-beck
commented
Sep 14, 2024
Comment on lines
+46
to
+50
| import org.hamcrest.CoreMatchers; | ||
| import org.hamcrest.MatcherAssert; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.startsWith; | ||
| import static org.hamcrest.MatcherAssert.assertThat; |
There was a problem hiding this comment.
The existing annotation failed at first without a useful message, so I switched to Hamcrest as it reports a difference.
| } | ||
|
|
||
| public JellyException(Throwable cause) { | ||
| super(cause.getLocalizedMessage()); | ||
| this.cause = cause; | ||
| super(cause); |
There was a problem hiding this comment.
This changes behavior, see the adapted test. I don't feel strongly about this, so would be happy to restore the previous behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-73774 for motivation in Jenkins.
Testing done
Autotests only so far.
Submitter checklist