Fixed #398 - Replace literal status codes with constants

jenkinsci · Apr 1, 2019 · e252da2 · e252da2
1 parent 3dcf840
commit e252da2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/jenkins-client/src/main/java/com/offbytwo/jenkins/model/Build.java b/jenkins-client/src/main/java/com/offbytwo/jenkins/model/Build.java
@@ -8,6 +8,7 @@
 
 import java.io.IOException;
 
+import org.apache.http.HttpStatus;
 import org.apache.http.client.HttpResponseException;
 
 public class Build extends BaseModel {
@@ -122,6 +123,7 @@ public TestReport getTestReport() throws IOException {
      * @throws IOException in case of an error.
      */
     public TestResult getTestResult() throws IOException {
+
         return client.get(this.getUrl() + "/testReport/?depth=1", TestResult.class);
     }
 
@@ -141,7 +143,7 @@ public String Stop() throws HttpResponseException, IOException {
 
             return client.get(url + "stop");
         } catch (HttpResponseException ex) {
-            if (ex.getStatusCode() == 405) {
+            if (ex.getStatusCode() == HttpStatus.SC_METHOD_NOT_ALLOWED) {
                 stopPost();
                 return "";
             }
@@ -164,7 +166,7 @@ public String Stop(boolean crumbFlag) throws HttpResponseException, IOException
 
             return client.get(url + "stop");
         } catch (HttpResponseException ex) {
-            if (ex.getStatusCode() == 405) {
+            if (ex.getStatusCode() == HttpStatus.SC_METHOD_NOT_ALLOWED) {
                 stopPost(crumbFlag);
                 return "";
             }