Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #64 from jenkinsci/dependabot/maven/org.codehaus.mojo-versions-maven-plugin-2.16.0" #67

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 29, 2023

#64 seems to break tests locally for some reason. (But not on CI, which is still using Maven 3.8.8.)

$ mvn -pl maven-plugin surefire:test
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
[INFO] 
[INFO] ------< io.jenkins.tools.incrementals:incrementals-maven-plugin >-------
[INFO] Building incrementals-maven-plugin 1.7-SNAPSHOT
[INFO]   from pom.xml
[INFO] ----------------------------[ maven-plugin ]----------------------------
[INFO] 
[INFO] --- surefire:3.1.2:test (default-cli) @ incrementals-maven-plugin ---
[INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.486 s
[INFO] Finished at: 2023-06-29T16:42:59-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-cli) on project incrementals-maven-plugin: Execution default-cli of goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test failed: org.junit.platform.commons.JUnitException: TestEngine with ID 'junit-vintage' failed to discover tests: Unsupported version of junit:junit: 3.8.1. Please upgrade to version 4.12 or later. -> [Help 1]

Tree:

[INFO] +- org.codehaus.mojo:versions-maven-plugin:jar:2.16.0:compile
[INFO] |  +- org.codehaus.mojo.versions:versions-model:jar:2.16.0:compile
[INFO] |  +- org.codehaus.mojo.versions:versions-model-report:jar:2.16.0:compile
[INFO] |  +- org.codehaus.mojo.versions:versions-common:jar:2.16.0:compile
[INFO] |  |  +- org.codehaus.mojo.versions:versions-api:jar:2.16.0:compile
[INFO] |  |  \- org.apache.commons:commons-collections4:jar:4.4:compile
[INFO] |  +- org.apache.maven.reporting:maven-reporting-impl:jar:3.2.0:compile
[INFO] |  |  +- org.apache.maven.reporting:maven-reporting-api:jar:3.1.1:compile
[INFO] |  |  +- org.apache.maven.doxia:doxia-decoration-model:jar:1.11.1:compile
[INFO] |  |  \- org.apache.maven.doxia:doxia-integration-tools:jar:1.11.1:compile
[INFO] |  |     \- org.codehaus.plexus:plexus-container-default:jar:1.0-alpha-9:compile
[INFO] |  |        +- junit:junit:jar:3.8.1:compile

Somehow related to #60.

…en/org.codehaus.mojo-versions-maven-plugin-2.16.0"

This reverts commit 00066a8, reversing
changes made to c83b4d8.
@jglick jglick requested a review from a team as a code owner June 29, 2023 19:40
@jglick jglick added the dependencies Pull requests that update a dependency file label Jun 29, 2023
@basil
Copy link
Member

basil commented Jun 29, 2023

Have you tried to fix the problem rather than reverting the original change?

@basil
Copy link
Member

basil commented Jun 29, 2023

Works fine for me locally with Java 8 (Eclipse Temurin) and Maven 3.9.2.

@jglick
Copy link
Member Author

jglick commented Jun 29, 2023

Might be specific to Java 11, not sure. Anyway now reproduced on CI, so proceeding with revert since this was not an important update to begin with. Not inclined to chase down root cause currently (something about JUnit 3 being in the dependency tree).

@jglick jglick merged commit 95b0117 into jenkinsci:master Jun 29, 2023
@jglick jglick deleted the revert-versions-maven-plugin branch June 29, 2023 21:12
@jglick
Copy link
Member Author

jglick commented Jun 29, 2023

(Anyone can of course propose the same update at any time in the future, with the build fixed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants