Skip to content

Conversation

offa
Copy link
Contributor

@offa offa commented Aug 10, 2021

Implementations of deprecated AbstractStepImpl / AbstractSynchronousNonBlockingStepExecution replaced.

Additionally some minor improvements (final and @NonNull related), missed in the previous PR.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit a63e923 into jenkinsci:master Aug 10, 2021
@offa offa deleted the step_api branch August 11, 2021 17:03
@basil
Copy link
Member

basil commented Oct 19, 2021

@offa FYI this should have also included the changes in #82 for completeness. There were no problems or regressions, so not a big deal, but perhaps useful to note for future changes.

@offa
Copy link
Contributor Author

offa commented Oct 20, 2021

Seems I've missed that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants