Skip to content

Upgrade HtmlUnit from 2.x to 3.x #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

Upgrade HtmlUnit from 2.x to 3.x #148

merged 1 commit into from
Jun 6, 2023

Conversation

timja-bot
Copy link
Contributor

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot requested a review from a team as a code owner June 6, 2023 07:23
@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 6, 2023
MarkEWaite
MarkEWaite approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit dd57711 into jenkinsci:master Jun 6, 2023
@MarkEWaite MarkEWaite mentioned this pull request Jun 22, 2023
Merged
6 tasks
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Jun 22, 2023
@MarkEWaite
Let markewaite adopt http-request plugin
ca87a36 
The http-request plugin needs a new release to deliver the features
and bug fixes that have accumulated since its last release in Aug 2022.
Some of those new features and bug fixes include:

* Require Jenkins 2.361.4 as minimum Jenkins version
  (jenkinsci/http-request-plugin#128)
* JENKINS-69081 - Track credential usage
  (jenkinsci/http-request-plugin#113)
* JENKINS-69155 - Snapshot authentication credentials
  (jenkinsci/http-request-plugin#111)
* Upgrade HtmlUnit from 2.x to 3.x
  (jenkinsci/http-request-plugin#148)

Documentation improvements include:

* Improve feature descriptions in documentation
  (jenkinsci/http-request-plugin#141)
* Add URL details as part of the exception
  (jenkinsci/http-request-plugin#74)
* Add a response header example to documentation
  (jenkinsci/http-request-plugin#133)
* rewording of abstract section
  (jenkinsci/http-request-plugin#130)
* Drop redundant part of example
  (jenkinsci/http-request-plugin#122)

Maintenance improvements include:

* Remove divBasedFormLayout from jelly files
  (jenkinsci/http-request-plugin#149)

jenkinsci/http-request-plugin#150 is the pull
request that prompted this adoption request

Reverts part of pull request:

* jenkins-infra#2950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timja-bot @MarkEWaite @timja