Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 'Test Vault Secrets retrieval' Button #244

Merged

Conversation

jamesrobson-secondmind
Copy link

Part of the change in #228 broke the 'Test Vault Secrets retrieval' button because it would pass in an empty string for the prefixPath and namespace if they were not set.
This problem does not affect use of secrets in jobs, it is only encountered when trying to check settings while adding/updating credentials.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jetersen jetersen merged commit ed18810 into jenkinsci:master Jul 27, 2022
@jetersen jetersen added the bug label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants