Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jenkins 66322 prepare for upgraded guava #7

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

simschla
Copy link
Member

Reimplement PR#6 and modernize pom.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job modernizing this plugin! Ideally, we would also add a Jenkinsfile to this repository and ensure that the CI build is passing, as well as moving the documentation from the wiki to README.md. Let me know if you need any advice about how to do that.

@simschla
Copy link
Member Author

simschla commented Aug 19, 2021

@basil I'll gladly do that. Can you point me to the documentation of these aspects (CI-build and moving the documentation)?

@basil
Copy link
Member

basil commented Aug 19, 2021

For the documentation, start by merging PR #5. That will take care of the docs. :-)

For the build/CI, start by rebasing this commit on top of #4 and then add a Jenkinsfile. For an example, take a look at jenkinsci/http-request-plugin#68 which I refreshed about two weeks ago. In that PR, I added a Jenkinsfile like

/*
 * See the documentation for more options:
 * https://github.com/jenkins-infra/pipeline-library/
 */
buildPlugin(useAci: true, configurations: [
  // Test the long-term support end of the compatibility spectrum (i.e., the minimum required
  // Jenkins version).
  [ platform: 'linux', jdk: '8', jenkins: null ],

  // Test the common case (i.e., a recent LTS release).
  [ platform: 'linux', jdk: '8', jenkins: '2.289.3' ],

  // Test the bleeding edge of the compatibility spectrum (i.e., the latest supported Java runtime).
  [ platform: 'linux', jdk: '11', jenkins: '2.289.3' ],
])

to run three parallel builds. You might do similar. Once that is done, you should get a CI run and a green or red checkmark in the PR, depending on whether the build passed or failed.

@simschla simschla force-pushed the feature/JENKINS-66322-prepare-for-upgraded-guava branch from d7ab8a1 to 8edef67 Compare August 20, 2021 03:58
@simschla simschla force-pushed the feature/JENKINS-66322-prepare-for-upgraded-guava branch from 20b4831 to 8b85154 Compare August 20, 2021 08:05
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job refreshing this plugin!

@basil
Copy link
Member

basil commented Aug 22, 2021

@simschla 🚢 🇮🇹 ?

@simschla simschla merged commit 7bb4c69 into master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants