-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jenkins 66322 prepare for upgraded guava #7
Feature/jenkins 66322 prepare for upgraded guava #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job modernizing this plugin! Ideally, we would also add a Jenkinsfile
to this repository and ensure that the CI build is passing, as well as moving the documentation from the wiki to README.md
. Let me know if you need any advice about how to do that.
@basil I'll gladly do that. Can you point me to the documentation of these aspects (CI-build and moving the documentation)? |
For the documentation, start by merging PR #5. That will take care of the docs. :-) For the build/CI, start by rebasing this commit on top of #4 and then add a
to run three parallel builds. You might do similar. Once that is done, you should get a CI run and a green or red checkmark in the PR, depending on whether the build passed or failed. |
d7ab8a1
to
8edef67
Compare
20b4831
to
8b85154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job refreshing this plugin!
@simschla 🚢 🇮🇹 ? |
Reimplement PR#6 and modernize pom.