Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clean lost node without requiring a instanceId #503

Merged
merged 36 commits into from
Jan 21, 2025
Merged

Update clean lost node without requiring a instanceId #503

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
a91653c
clean lost node working
gbhat618 Jan 2, 2025
c3201ac
developing test
gbhat618 Jan 3, 2025
65bd743
revert the ITUtil changes
gbhat618 Jan 3, 2025
40a1222
Squashed commit of the following:
gbhat618 Jan 3, 2025
b7de0f2
clean nodes in working - needs some more cleanup
gbhat618 Jan 3, 2025
e96b05a
tests and code in working codition
gbhat618 Jan 4, 2025
ca8e589
update the compute client v2 integration tests
gbhat618 Jan 4, 2025
7f2d305
improve comments and small code updates
gbhat618 Jan 4, 2025
caae499
Revert "Squashed commit of the following:"
gbhat618 Jan 4, 2025
97c74c7
minor improvements comments and code
gbhat618 Jan 4, 2025
fe03a64
Update src/test/java/com/google/jenkins/plugins/computeengine/integra…
gbhat618 Jan 7, 2025
dcda478
Update src/test/java/com/google/jenkins/plugins/computeengine/integra…
gbhat618 Jan 7, 2025
92bd182
Update src/test/java/com/google/jenkins/plugins/computeengine/integra…
gbhat618 Jan 7, 2025
e47588d
Update src/test/java/com/google/jenkins/plugins/computeengine/integra…
gbhat618 Jan 7, 2025
4e322d7
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 7, 2025
9c840b5
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 7, 2025
f17d80e
Update src/test/java/com/google/jenkins/plugins/computeengine/integra…
gbhat618 Jan 7, 2025
6315666
Update src/test/java/com/google/jenkins/plugins/computeengine/integra…
gbhat618 Jan 7, 2025
4cd89ca
Squashed commit of the following:
gbhat618 Jan 7, 2025
5484655
improve code and fix ComputeClientV2 intialization
gbhat618 Jan 7, 2025
38bb7f6
Revert "Squashed commit of the following:"
gbhat618 Jan 7, 2025
fabd527
Merge branch 'develop' of github.com:jenkinsci/google-compute-engine-…
gbhat618 Jan 7, 2025
c243b28
spotless
gbhat618 Jan 7, 2025
1071692
more accurate log message
gbhat618 Jan 7, 2025
0a15aa7
update log recorder with static list to capture more log records than…
gbhat618 Jan 7, 2025
3a8030b
update DateFormatter formatting requirement docs
gbhat618 Jan 7, 2025
012cdc7
add Locale.ROOT in lowercase and uppercase coversions
gbhat618 Jan 7, 2025
a87a569
improve the comment with better clarity
gbhat618 Jan 7, 2025
458b0a8
use the format with hard coded zone info for readability, so no requi…
gbhat618 Jan 7, 2025
deb6d70
remove the non-required javadoc in timestamp string
gbhat618 Jan 7, 2025
28cc50d
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 7, 2025
da07d6f
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 16, 2025
ee35bbb
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 16, 2025
ee6ad39
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 16, 2025
c8ec0dd
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo…
gbhat618 Jan 16, 2025
fec2061
spotless-apply after applying review suggestions
gbhat618 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/main/java/com/google/jenkins/plugins/computeengine/CleanLo… 
…stNodesWork.java

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
  • Loading branch information
@gbhat618 @jglick
gbhat618 and jglick authored Jan 7, 2025
commit 4e322d781c05c0d4ad0be27689d584687673856e
2 changes: 1 addition & 1 deletion src/main/java/com/google/jenkins/plugins/computeengine/CleanLostNodesWork.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class CleanLostNodesWork extends PeriodicWork {
protected final Logger logger = Logger.getLogger(getClass().getName());
public static final String NODE_IN_USE_LABEL_KEY = "jenkins_node_in_use";
public static final long RECURRENCE_PERIOD = Long.parseLong(
System.getProperty("jenkins.cloud.gcp.cleanLostNodesWork.recurrencePeriod", String.valueOf(HOUR)));
System.getProperty(CleanLostNodesWork.class.getName() + ".recurrencePeriod", String.valueOf(HOUR)));
public static final int LOST_MULTIPLIER = 3;
gbhat618 marked this conversation as resolved.
Show resolved Hide resolved

/** {@inheritDoc} */
Expand Down
Loading