Skip to content

Conversation

@mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 25, 2024

  • replace yui dialogs with the jenkins built-in dialogs (there is no yui code left, all yui modules are deleted)
  • use symbols (old icons are deleted)
  • use jenkins form classes for radios, inputs, checkboxes
  • remove the back to dashboard links to by in sync with the recommendations with the design library
  • use flatpickr-api plugin to have a date-time picker for the search
  • use notifications
  • use jenkins-table to show search results, table is resizeable, console link moved to end of row, use model links

This fixes JENKINS-62457, JENKINS-47727

Screenshots

image
image
image
image

Testing done

Manual testing

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

- replace yui dialogs with the jenkins built-in dialogs (there is no
  yui code left, all yui modules are deleted)
- use symbols (old icons are deleted)
- use jenkins form classes for radios, inputs, checkboxes
- remove the back to dashboard links to by in sync with the
  recommendations with the design library
@mawinter69 mawinter69 requested a review from a team as a code owner July 25, 2024 00:21
@NotMyFault NotMyFault requested a review from balakine July 27, 2024 11:31
@balakine balakine merged commit e03f19d into jenkinsci:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants