-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC Milestone 2] Migrating WebHook Draft #1520
Closed
harsh-ps-2003
wants to merge
12
commits into
jenkinsci:gsoc-2023-project
from
harsh-ps-2003:milestone2wip
Closed
[GSoC Milestone 2] Migrating WebHook Draft #1520
harsh-ps-2003
wants to merge
12
commits into
jenkinsci:gsoc-2023-project
from
harsh-ps-2003:milestone2wip
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is non-functional currently, but I still made the Draft PR so that the approach towards the migration could be verified in code. |
The PR is now functioning interactively. Tests for it are WIP. |
Noted 👍🏼 |
krisstern
changed the title
[GSoC Milestone 2] Migrating WebHook
[GSoC Milestone 2] Migrating WebHook Draft
Jul 31, 2023
Replaced by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the old manual Webhook implementation to GitLab4J-API event-based Webhook.
This PR is based on Milestone 1 code.
CauseData has not been affected yet.
Tests not adapted yet.
NOT WORKING
This draft pr is to collaborate on fixing issues.