Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC Milestone 2] Migrating WebHook Draft #1520

Closed

Conversation

harsh-ps-2003
Copy link
Contributor

Migrating the old manual Webhook implementation to GitLab4J-API event-based Webhook.
This PR is based on Milestone 1 code.
CauseData has not been affected yet.
Tests not adapted yet.

NOT WORKING

This draft pr is to collaborate on fixing issues.

@harsh-ps-2003
Copy link
Contributor Author

harsh-ps-2003 commented Jun 27, 2023

This PR is non-functional currently, but I still made the Draft PR so that the approach towards the migration could be verified in code.
The compilation errors in CI are due to compilation errors in tests.

@harsh-ps-2003
Copy link
Contributor Author

harsh-ps-2003 commented Jul 19, 2023

The PR is now functioning interactively. Tests for it are WIP.
@basil kindly take a look please.

@krisstern
Copy link
Member

The PR is now functioning interactively. Tests for it are WIP.

Noted 👍🏼

@krisstern krisstern changed the title [GSoC Milestone 2] Migrating WebHook [GSoC Milestone 2] Migrating WebHook Draft Jul 31, 2023
@MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants