Skip to content

Conversation

@basil
Copy link
Member

@basil basil commented Nov 6, 2024

Definitely the easiest CSP fix I have seen in this project. All of the code was commented out and thus can trivially be deleted. The code appears to have been commented out since it was originally checked in at commit 0a0471b.

Testing done

mvn clean verify
No manual testing, as this code was commented out all along.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…labbranchsource/GitLabSCMSource/config-detail.jelly`
@basil basil added the internal label Nov 6, 2024
@basil basil requested a review from yaroslavafenkin November 6, 2024 22:49
@basil basil requested a review from jetersen as a code owner November 6, 2024 22:49
@basil basil merged commit 9a03496 into jenkinsci:master Nov 8, 2024
18 checks passed
@basil basil deleted the JENKINS-74070 branch November 8, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants