Skip to content

Conversation

@nathan-objective
Copy link
Contributor

@nathan-objective nathan-objective commented Aug 22, 2024

… version of Jenkins

The new version is needed to solve a breaking change in the gitlab4j dependency.

Fixes #435

Testing done

This change was tested by replaying the manual operation that was causing the error, when saving a pipeline and validating that the plugin did not cause the error.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

… version of Jenkins

The new version is needed to solve a breaking change in the gitlab4j dependency.
@trinaryouroboros
Copy link

@jetersen +1 can this be approved and merged?

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Aug 27, 2024

The breaking change in the GitLab4J API will require lock-step upgrades of the API plugin and its consumers like GitLab branch source plugin. If users upgrade the API plugin without upgrading the consumers (like GitLab branch source), they will see runtime errors. If users upgrade the consumers without upgrading the API plugin, they will see runtime errors.

It would be much better to not have a breaking change in the API. I've proposed to remove the breaking change from the GitLab4J API with pull request:

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Aug 27, 2024

After more thinking, I believe that the lock-step upgrade is better than the current state where users must choose to not install the most recent release of the GitLab API plugin. When this pull request is merged and released, it will cause the GitLab branch source plugin to require GitLab API plugin 5.6.0-97.v6603a_83f8690 which is a positive step and confirmed working by @nathan-objective .

That doesn't protect users that choose to upgrade GitLab API plugin without upgrading GitLab branch source plugin, but those users can be told to upgrade both plugins, not just the API plugin.

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@basil basil added the bug Something isn't working label Aug 27, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil enabled auto-merge (squash) August 27, 2024 17:32
@basil basil disabled auto-merge August 27, 2024 17:33
@basil basil enabled auto-merge (squash) August 27, 2024 17:33
@basil basil changed the title Updated the Jenkins version property and the BOM to match the current… Updated the Jenkins version property and the BOM Aug 27, 2024
@basil basil merged commit 1f5c66d into jenkinsci:master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NoSuchMethodError: org.gitlab4j.api.ProjectApi.addHook(Object, String, ProjectHook, boolean, String)

4 participants