Skip to content

Conversation

@lmife
Copy link
Contributor

@lmife lmife commented Dec 12, 2023

Actually, the functionality was already there. Switched from using the GitLab Server URL from the Jenkins config to the public web URL provided by the GitLab server itself. Also fixed wrong LOGGER calls.

This fixes #380

Testing done

Used in test and staging environment. Checked all links inside the scan log, project page, branch page and build page. All links are using the correct URL, now.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Actually, the functionality was already there. Switched from using the GitLab Server URL from the Jenkins config to the public web URL provided by the GitLab server itself. 
Also fixed wrong LOGGER calls.
@lmife lmife requested a review from jetersen as a code owner December 12, 2023 18:45
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetersen jetersen added the bug Something isn't working label Jan 18, 2024
@jetersen jetersen merged commit a285158 into jenkinsci:master Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong link URLs to GitLab

2 participants