Skip to content

Conversation

@jmini
Copy link
Contributor

@jmini jmini commented Jun 10, 2023

Fixes #329

The GitLabHelper now handles the case where the server ends with a / when computing links.

Testing done

Tested in a local instance

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jmini jmini requested a review from jetersen as a code owner June 10, 2023 15:43
@jmini
Copy link
Contributor Author

jmini commented Jun 15, 2023

@jetersen can you have a look?

@jetersen jetersen added the bug Something isn't working label Jun 15, 2023
@jetersen jetersen merged commit bcfd141 into jenkinsci:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links to gitlab are wrong when the server ends with a slash

2 participants