Option to ignore type in build StatusName #307
Conversation
mifitous
force-pushed
the
discard-type-in-full-name
branch
from
1222fb0 to
9df28c7
Compare
|
Hi @jetersen |
| String statusName = GitLabPipelineStatusNotifier.getStatusName(sourceContext, null, revision, | ||
| new hudson.EnvVars()); | ||
|
|
||
| assertThat(statusName, is(GitLabPipelineStatusNotifier.GITLAB_PIPELINE_STATUS_PREFIX |
There was a problem hiding this comment.
Maybe instead of referencing constants here, write the actual literal expected value. Changing the value is an API break essentially?
Started external GitLab pipeline can't finish if the plugin is updated in between - jenkins pipelines can "in theory" run across Jenkins restarts...
There was a problem hiding this comment.
We had a similar issue when changing the project config Discover merge requests from forks:
- old value:
Discover merge requests from forks - new value:
The current merge request revision
That has the side effect to report the job status to be reported as jenkinsci/mr-head on GitLab instead of jenkinsci/mr-merge.
You also end up with tons of pipeline jenkinsci/mr-merge the are "running" forever:
For me you just need to accept that and be prepared to run some curl command to make the pipeline green using the REST API: https://docs.gitlab.com/ee/api/commits.html#set-the-pipeline-status-of-a-commit
curl --location '****gitlab-server****/api/v4/projects/****project-id****/statuses/****commit-sha****' \
--header 'Content-Type: application/json' \
--header 'PRIVATE-TOKEN: ****************' \
--data '{
"state": "success",
"name": "jenkinsci/mr-merge"
}'
There was a problem hiding this comment.
This PR is an attempt to resolve such problems by removing the type from the pipeline name... because GitLab is not GitHub and - depending on how you use the branch source - the type may not make sense.
There was a problem hiding this comment.
I am well aware about what this change is about.
We are interested to have a single name instead of:
jenkinsci/branch and jenkins/mr-head
In order to avoid 2 external pipeline report in Jenkins…
| <f:entry title="${%Overwrite full name}" field="buildStatusNameOverwrite"> | ||
| <f:checkbox default="unchecked"/> | ||
| </f:entry> | ||
| <f:entry title="${%Do not append type in status name}" field="ignoreTypeInStatusName"> |
|
@mifitous I support your proposal to add this! Let me know if I can help… |
|
There are currently conflicts, would you mind resolving them? 😓 |
mifitous
force-pushed
the
discard-type-in-full-name
branch
from
75e7bb3 to
5cb346c
Compare
…s/GitLabPipelineStatusNotifierTest.java
Hi @jetersen : done |
4 participants
Implement @cobexer request #176 (comment)
Add a checkbox to allow ignoring type in build StatusName