Skip to content

Conversation

@jmini
Copy link
Contributor

@jmini jmini commented Aug 23, 2022

Fixes #207

As discussed in #210 (comment), since the prefix can be glpat- or anything (from empty String to anything more) see https://docs.gitlab.com/ee/user/admin_area/settings/account_and_limit_settings.html#personal-access-token-prefix

The check should be changed to accept 20 characters or more.

I reworked commit proposed by @sebastiangraf (added as co-author of my commit) in #210


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jmini jmini requested a review from jetersen as a code owner August 23, 2022 20:19
@jetersen jetersen added the bug Something isn't working label Aug 23, 2022
@jetersen jetersen merged commit 55fd814 into jenkinsci:master Aug 23, 2022
@jetersen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin's PAT requirements don't match what gitlab generates

2 participants