Skip to content

Fix the directory check method #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jetersen merged 2 commits into from
Jun 27, 2022
Merged

Fix the directory check method #217

jetersen merged 2 commits into from
Jun 27, 2022

Conversation

@seanly
Copy link
Contributor

@seanly seanly commented Jun 27, 2022

Fixed the directory check method. When the directory does not exist, the data obtained by the interface is 0 instead of an exception.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@seanly seanly requested a review from jetersen as a code owner June 27, 2022 14:10
jetersen
jetersen approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetersen jetersen enabled auto-merge (squash) June 27, 2022 14:15
@jetersen jetersen changed the title Fix the directory check method. Fix the directory check method Jun 27, 2022
@seanly
Copy link
Contributor Author

seanly commented Jun 27, 2022 •
edited
Loading

Can this bugfix be considered for a release? @jetersen

@jetersen jetersen merged commit bcc7660 into jenkinsci:master Jun 27, 2022
@seanly seanly deleted the fix/scm-file-type branch June 27, 2022 14:28
@jetersen jetersen added the bug Something isn't working label Jun 27, 2022
@jetersen
Copy link
Member

jetersen commented Jun 27, 2022

@seanly release build running: https://github.com/jenkinsci/gitlab-branch-source-plugin/runs/7075368680?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jetersen jetersen jetersen approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanly @jetersen