Remove GITLAB_COMMIT_* environment variables.
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables are liable to contain overlong values that cause problems launching processes on Windows. See: https://devblogs.microsoft.com/oldnewthing/20100203-00/?p=15083 GitLab's own CI doesn't include environment variables for commit messages, changed files, etc: https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Also, this functionality has never worked properly. Expressions like: "GITLAB_COMMIT_ID_" + index+1 Result in strings like `"GITLAB_COMMIT_ID_31"` rather than `"GITLAB_COMMIT_ID_4"`! Needs more brackets :-).
Contributor
Author
|
Hey @jetersen, what do you think about this patch? Thanks! |
Member
|
What about keeping a reference to the latest
Also checkstyle have 3 new issues. |
Contributor
Author
There's more portable ways to get at that info: check the
I brought it up only to show that no-one is using it; if they were, the off-by-one bug would have been reported already, I think.
Fixed! Thanks. |
jetersen
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variables are liable to contain overlong values that cause problems launching processes on Windows. See: https://devblogs.microsoft.com/oldnewthing/20100203-00/?p=15083
GitLab's own CI doesn't include environment variables for commit messages, changed files, etc: https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
Also, this functionality has never worked properly. Expressions like:
Result in strings like
"GITLAB_COMMIT_ID_31"rather than"GITLAB_COMMIT_ID_4"whenindex=3! Needs more brackets :-).Fixes #215