support extracting MR id when using both strategy #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
approved these changes
Apr 15, 2022
jetersen
approved these changes
Apr 15, 2022
Contributor
Author
|
@jetersen I did all the tests I could think of (new branch, single MR job and dual MR jobs), all were started correctly and notifies gitlab when the job started and completed. If you think it is ok to merge I'd appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
Overrides #165
@jetersen
I never liked the split either but I thought I'd stick with what was there.
Let me know if this is more to your liking.
I'll install it on our test jenkins instance to make sure it works as expected (can't remember if there was another issue and that's why I had that logic to revert to using the project name instead of the id in my other PR).