Support setting build status when MR is from another project

[callum-p]

Currently if you have a fork in another project and try to do an MR into the main project, the API will return a 404 because it is looking for the commit in the wrong project. See jenkinsci/gitlab-plugin#549 for similar problem discussion.

The change here is that now it will use the Gitlab API to find the source project ID instead of assuming it is the same. Also fixes a bug where the ref isn't sent as part of the status check, which caused status checks to not update for the correct MR when there is an MR and a branch with the same head sha.

This has fixed it for me.

Not a java dev, but hopefully this isn't too bad.

[aksenov007]

A must-have feature, @baymac @markyjackson-taulia @Casz @justinharringa could you have a look at this, please?

[aksenov007]

The block could be rewritten in this way:

            Integer projectId = (revision instanceof MergeRequestSCMRevision) ? getSourceProjectId(build.getParent(), gitLabApi, source.getProjectPath()) : source.getProjectPath()
            gitLabApi.getCommitsApi().addCommitStatus(
                projectId,
                hash,
                state,
                status);

[callum-p]

Thanks for the tip. That didn't quite work, it produced the below error.

[ERROR] /build/src/main/java/io/jenkins/plugins/gitlabbranchsource/helpers/GitLabPipelineStatusNotifier.java:[306,178] incompatible types: bad type in conditional expression

I did expand upon your suggested change and managed to get it working. PR updated.

[callum-p]

Nevermind, reverted. Had some linting errors and I can't really be bothered spending any more time on this.

[aksenov007]

The block could be rewritten in this way:

            Integer projectId = (revision instanceof MergeRequestSCMRevision) ? getSourceProjectId(build.getParent(), gitLabApi, source.getProjectPath()) : source.getProjectPath()
            gitLabApi.getCommitsApi().addCommitStatus(
                projectId,
                hash,
                state,
                status);

[amit-gueta]

Currently if you have a fork in another project and try to do an MR into the main project, the API will return a 404 because it is looking for the commit in the wrong project.

Hi,
Currently it doesn't even trigger an MR if my repo is a fork, how did you configure it to work with fork repos?
I'm getting in the log - "Ignoring merge requests as project is a mirror..."

(sorry if it's not the right place for my message)

[callum-p]

Currently if you have a fork in another project and try to do an MR into the main project, the API will return a 404 because it is looking for the commit in the wrong project.

Hi,
Currently it doesn't even trigger an MR if my repo is a fork, how did you configure it to work with fork repos?
I'm getting in the log - "Ignoring merge requests as project is a mirror..."

(sorry if it's not the right place for my message)

Is it a fork in the same organization? It is in my case

[amit-gueta]

Currently if you have a fork in another project and try to do an MR into the main project, the API will return a 404 because it is looking for the commit in the wrong project.

Hi,
Currently it doesn't even trigger an MR if my repo is a fork, how did you configure it to work with fork repos?
I'm getting in the log - "Ignoring merge requests as project is a mirror..."
(sorry if it's not the right place for my message)

Is it a fork in the same organization? It is in my case

Yes, it is in the same organization.
but I didn't use "Gitlab group" in jenkins, I used "Multibranch".. maybe because of this?

[callum-p]

@MarkEWaite @markyjackson-taulia can you have a look at this?

[callum-p]

@baymac @markyjackson-taulia @Casz @justinharringa bump.

Can we get a simple review on a 60 line change, and possibly an approval? Do I need to do something else to expedite this process? Ridiculous.

[LinuxSuRen]

LGTM