Migrate from Acegi compatibility layer to Spring Security 6.x #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samrocketman Are you interested in testing this on a real Jenkins/GitHub installation? |
basil
commented
Jan 17, 2025
Comment on lines
-39
to
-52
| @Override | ||
| public GrantedAuthority[] getAuthorities() { | ||
| if (!hasGrantedAuthorities) { | ||
| try { | ||
| GHUser user = authenticationToken.loadUser(getUsername()); | ||
| if(user != null) { | ||
| setAuthorities(authenticationToken.getAuthorities()); | ||
| } | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| return super.getAuthorities(); | ||
| } |
There was a problem hiding this comment.
In Spring Security 6.x, the parent class is immutable, so pushing this logic up to the caller.
Sure, there are a few ways I can test this. I’ll report back next week with some testing in AWS and locally on my machine. |
|
Hi @samrocketman, any luck testing this? |
6 tasks
Merged
6 tasks
|
@basil apologies I didn’t get around to testing this, got busy, and forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin continues to work on 2.479.x LTS, but only through a number of old compatibility layers. This is inefficient, and we cannot keep supporting these compatibility layers forever. This PR migrates away from the compatibility layers to the latest Spring Security 6.x and Jenkins APIs.
Testing done
mvn clean verifySubmitter checklist