Skip to content

Issue-361: Add prudent information about a publishing of checks. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Issue-361: Add prudent information about a publishing of checks. #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/java/io/jenkins/plugins/checks/github/GitHubChecksPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ public void publish(final ChecksDetails details) {

context.addActionIfMissing(run.getId(), gitHubDetails.getName());

buildLogger.log("GitHub check (name: %s, status: %s) has been published.", gitHubDetails.getName(),
gitHubDetails.getStatus());
SYSTEM_LOGGER.fine(format("Published check for repo: %s, sha: %s, job name: %s, name: %s, status: %s",
buildLogger.log("GitHub check (name: %s, status: %s, url: %s) has been published.",
gitHubDetails.getName(),
gitHubDetails.getStatus(),
gitHub.getApiUrl());
SYSTEM_LOGGER.fine(format("Published check for url: %s, repo: %s, sha: %s, job name: %s, name: %s, status: %s",
gitHub.getApiUrl(),
context.getRepository(),
context.getHeadSha(),
context.getJob().getFullName(),
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/io/jenkins/plugins/checks/github/GitHubChecksPublisherITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ public static Collection<Object[]> contextBuilders() {
*/
@Test
public void shouldPublishGitHubCheckRunCorrectly() {
loggerRule.record(GitHubChecksPublisher.class.getName(), Level.WARNING).capture(1);

ChecksDetails details = new ChecksDetailsBuilder()
.withName("Jenkins")
.withStatus(ChecksStatus.COMPLETED)
Expand Down Expand Up @@ -206,6 +208,13 @@ public void shouldPublishGitHubCheckRunCorrectly() {
new PluginLogger(j.createTaskListener().getLogger(), "GitHub Checks"),
wireMockRule.baseUrl())
.publish(details);

assertThat(loggerRule.getRecords().size()).isEqualTo(1);
assertThat(loggerRule.getMessages().get(0))
.contains("has been published.")
.contains("status: COMPLETED")
.contains("name: Jenkins")
.contains("url: example.com");
}

/**
Expand Down