Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the consequences of setting user.name and user.email #925

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Clarify the consequences of setting user.name and user.email #925

merged 1 commit into from
Aug 24, 2020

Conversation

cpfeiffer
Copy link
Contributor

It took me a while to realize that this plugin, in constrast to its documentation, does not alter user.name and user.email. So I took the additional time to adjust the documentation accordingly.

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

It only sets some environment variables and does *not* alter
and (local or global) git configuration.
@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Jul 4, 2020
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements and corrections!

@MarkEWaite MarkEWaite merged commit 7f03b9b into jenkinsci:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants