Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade matrix-project optional dependency for PCT #1627

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Aug 5, 2024

Downgrade matrix-project optional dependency for PCT

An attempt to pass PCT with the pre-release of git plugin 5.3.0

The plugin BOM run to assess the master branch of the git plugin fails two BOM tests, one on the 2.440.x line and one on the 2.452.x line. The failure can be duplicated locally with the command:

$ LINE=2.440.x PLUGINS=pipeline-model-definition  TEST=InjectedTest bash local-test.sh

[ERROR] org.jenkinsci.plugins.pipeline_model_definition.InjectedTest.testPluginActive -- Time elapsed: 0.001 s <<< FAILURE!
java.lang.AssertionError: While testing pipeline-model-definition, git failed to start
        at org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests.testPluginActive(PluginAutomaticTestBuilder.java:102)

Caused by: java.io.IOException: Failed to load: Git plugin (git 5.3.0-rc5283.29a_5456289b_2)
 - Update required: Matrix Project Plugin (matrix-project 822.824.v14451b_c0fd42) to be updated to 832.va_66e270d2946 or higher
        at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:988)

[ERROR] Failures:
[ERROR]   InjectedTest.testPluginActive While testing pipeline-model-definition, git failed to start

Testing done

Automated tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The plugin compatibility tester does not load the version of the optional
dependency that is specified by the plugin (git plugin in this case)
when loading plugins to test a plugin that depends on the git plugin
(pipeline-model-definition in this case).  Downgrading this optional
dependency should be harmless to other plugins and to users and may
allow the plugin compatibility tester to pass tests in the plugin bill
of materials.
@github-actions github-actions bot added the dependencies Dependency related change label Aug 5, 2024
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Aug 5, 2024
@MarkEWaite MarkEWaite marked this pull request as ready for review August 5, 2024 12:54
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 5, 2024 12:54
@MarkEWaite
Copy link
Contributor Author

The checks for the BOM test build show that this change resolved the test failure.

@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Aug 5, 2024
@MarkEWaite MarkEWaite merged commit c54ef07 into jenkinsci:master Aug 5, 2024
15 of 16 checks passed
@MarkEWaite MarkEWaite removed the dependencies Dependency related change label Aug 5, 2024
@MarkEWaite MarkEWaite deleted the workaround-pct-optional-import branch August 5, 2024 13:07
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Oct 4, 2024
jenkinsci/git-plugin#1664 is the pull request
that proposes the upgrade.

jenkinsci/git-plugin#1627 provides more details
about the conditions that forced the matrix project version to be managed
in the git plugin pom file instead of relying on the plugin BOM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant