Use correct getters for note fields

[sboardwell]

Use correct getters on NoteToPush

This PR corrects the getters used on the NoteToPush internal class of the GitPublisher class.

Checklist

• I have read the CONTRIBUTING doc
• Unit tests pass locally with my changes
• No Javadoc warnings were introduced with my changes
• No spotbugs warnings were introduced with my changes
• I have interactively tested my changes
• Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce?

• Bug fix (non-breaking change which fixes an issue)

Further comments

n/a

[rsandell]

Unfortunately for binary backwards compatibility the old method signatures needs to be kept and @Deprecated.

Also shouldn't there be needed changes in the config.jelly for the signature change?

[sboardwell]

Thanks @rsandell, will add the old method signatures back. And good catch with the jelly sections.

[sboardwell]

Reinstated the old methods.

I checked the config.jelly and the fields are referenced so it seems jelly does not need the official getters, just the constructor:

git-plugin/src/main/resources/hudson/plugins/git/GitPublisher/config.jelly

Lines 75 to 89 in 9f17f9a

	<f:entry title="${%Note to push}" field="noteMsg" >
	<f:textarea checkUrl="descriptorByName/GitPublisher/checkNoteMsg" checkDependsOn="" />
	</f:entry>
	<f:entry field="targetRepoName" title="${%Target remote name}">
	<f:textbox/>
	</f:entry>
	<f:entry title="${%Note's namespace}" field="noteNamespace">
	<f:textbox/>
	</f:entry>
	<f:entry field="noteReplace" >
	<f:checkbox title="${%Abort if note exists}" />
	</f:entry>