Fix erratic GitStatusTest #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test already had code that waits for jobs to complete on Windows. The improved job leak detection that was implemented in the Jenkins test harness will sometimes show the same conditions on Unix builds. Wait for jobs to complete on Windows and on Unix.
No need to complicate GitStatusTest with the test methods that do not require a JenkinsRule. Use a simpler test structure and a simpler test file for the GitStatusTest assertions that do not require a JenkinsRule.
Not an error, but surprising based on my testing. None of my test machines are fast enough to complete all the jobs without needing any time for waiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix erratic GitStatusTest
Test already had code that waits for jobs to complete on Windows. The improved job leak detection that was implemented in the Jenkins test harness will sometimes show the same conditions on Unix builds. Wait for jobs to complete on Windows and on Unix.
Checklist
Types of changes