Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional notifyCommit parameters #1477

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

samrocketman
Copy link
Member

See also
public HttpResponse doNotifyCommit(HttpServletRequest request, @QueryParameter(required=true) String url,
@QueryParameter() String branches, @QueryParameter() String sha1,
@QueryParameter() String token) {

Checklist

There's no associated Jira issue for this change. This is documentation only.

  • I have read the CONTRIBUTING doc
  • Documentation in README has been updated as necessary

There's no appropriate category for "Tyes of changes" except for maybe "Bug fix". This is documenting an existing feature that was previously undocumented.

See also https://github.com/jenkinsci/git-plugin/blob/a057f8460a26802bcc17acc13115371cf8fbcf69/src/main/java/hudson/plugins/git/GitStatus.java#L117-L119

There's no associated Jira issue for this change.  This is documentation only.

- [x] I have read the [CONTRIBUTING](https://github.com/jenkinsci/git-plugin/blob/master/CONTRIBUTING.adoc) doc
- [x] Documentation in README has been updated as necessary

There's no appropriate category for "Tyes of changes" except for maybe "Bug fix".  This is documenting an existing feature that was previously undocumented.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 5, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite MarkEWaite merged commit cc0d683 into jenkinsci:master Jul 6, 2023
@samrocketman samrocketman deleted the docs branch July 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants