Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silencing the list of remote branches so it doesn't spam the console log #8

Merged
merged 1 commit into from
Mar 29, 2013
Merged

Silencing the list of remote branches so it doesn't spam the console log #8

merged 1 commit into from
Mar 29, 2013

Conversation

jlabanca
Copy link

@ndeloof for review

Large git repositories with many developers can have hundreds of branches (multiple branches per developer), which makes it spammy to print them all out when fetching remote repositories. This change just prints out the total number of branches, unless the user requests verbose output.

@buildhive
Copy link

Jenkins » git-client-plugin #21 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@ndeloof
Copy link
Contributor

ndeloof commented Mar 26, 2013

make sense, but I'd prefer the reverse option, i.e. make git-client quiet by configuring extra parameters

@jlabanca
Copy link
Author

@ndeloof

I added GitClient.quietRemoteBranches to quiet this specific print loop. I also considered "quiet" or "lessVerbose", but "quiet" usually means don't print anything, and "lessVerbose" just doesn't sound correct (and conflicts with "verbose" if both are specified").

Let me know if you had something else in mind and I can reimplement it.

@buildhive
Copy link

Jenkins » git-client-plugin #22 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@jlabanca
Copy link
Author

Not sure where we left off. Do you want to merge this for me?

ndeloof added a commit that referenced this pull request Mar 29, 2013
Silencing the list of remote branches so it doesn't spam the console log
@ndeloof ndeloof merged commit 785adc7 into jenkinsci:master Mar 29, 2013
@jlabanca jlabanca deleted the jlabanca/less-verbose branch April 24, 2013 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants