Master add clone command tests #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CliGit and JGit implementations are different as noted in the comments of the test methods. Refer to the comments in the source file for some of the difference detected by the tests.
Desparately need a unit test oriented way to identify the stack trace of the code which opened a file so that the test failure can be assigned to a specific stack trace.
|
plugins » git-client-plugin #223 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
ndeloof
added a commit
that referenced
this pull request
Jan 12, 2014
Master add clone command tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests of the CloneCommand implementation.
The tests fail on Windows because they are unable to remove
the temporary directory after the test completes. That is the
pattern which was detected previously in JENKINS-19994.
More work is needed before the Jenkins JGit plugin closes
all the files it opens. These tests pass on Linux, and fail on
Windows with the message that the temp dir used for the
test cannot be deleted.