[JENKINS-47514] Don't let shell process password characters #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cat (Linux) and type (Windows) of files rather than echo of strings to send username and password to the git ssh commands to reduce the risk and complication of shell escaping username and password text provided by end users.
The Linux based ssh commands perform expansion of '%' in arguments to ssh, even if the '%' character is in the name of the file or directory.
Command line git shallow clone is only workable with command line git 1.9 and newer. Earlier versions cause strange behaviors in the plugin. Rather than complicate things with spurious failures on older command line git implementations (like CentOS 6 and CentOS 7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the risks that come when a user provided string is passed to the
echocommand (Windows and Linux). Place the strings inside a file andcatortypethe file instead.